Add config and an optional dependency for type checking with mypy #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually do a whole lot for existing code, because it's configured not to check the bodies of functions that don't have typed declarations. Meaningful checking can be introduced progressively from here; I started by configuring the pitch tracker modules to require type defs. Individual functions can also be checked, by adding types to their declarations. Unfortunately pyqtProperty isn't type-checkable and does produce errors, so there's a fair amount of error-suppression noise for it :(
|
Thank you @celeste-sinead, that's something that I wanted to try for a while (and actually started a bit locally, but never got to commit). That's a very good basis. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually do a whole lot for existing code, because it's configured not to check the bodies of functions that don't have typed declarations. Meaningful checking can be introduced progressively from here; I started by configuring the pitch tracker modules to require type defs. Individual functions can also be checked, by adding types to their declarations.
Unfortunately pyqtProperty isn't type-checkable and does produce errors, so there's a fair amount of error-suppression noise for it :(
I noticed this in #201