Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] stop running tests on test failure? #16

Closed
thoraxe opened this issue Aug 12, 2015 · 5 comments
Closed

[RFE] stop running tests on test failure? #16

thoraxe opened this issue Aug 12, 2015 · 5 comments

Comments

@thoraxe
Copy link

thoraxe commented Aug 12, 2015

I don't see any option/flag to make Urchin stop running tests if a test fails.

I'm actually trying to use Urchin as a setup framework for a piece of software. Rather than wrap every setup item in some weird bash block, Urchin seemed like a good fit, except for this one piece.

@tlevine
Copy link
Owner

tlevine commented Aug 12, 2015

How interesting! I would love to learn more of how Urchin could work
as a setup framework.

Implementing this would be straightforward, but there is no such flag at
the moment. Urchin discovers files recursively in directories, so I
think we would return something other than zero from the recursive
function when something fails and then propogate non-zero returns.

I'll explain further as to how to do this if you are interested in
writing it yourself; otherwise, you can wait until I or someone else
maybe writes it.

On 12 Aug 06:41, Erik M Jacobs wrote:

I don't see any option/flag to make Urchin stop running tests if a test fails.

I'm actually trying to use Urchin as a setup framework for a piece of software. Rather than wrap every setup item in some weird bash block, Urchin seemed like a good fit, except for this one piece.


Reply to this email directly or view it on GitHub:
#16

@thoraxe
Copy link
Author

thoraxe commented Aug 13, 2015

Thanks for the feedback. Here's an example of what I'm doing, kinda sorta:

https://github.com/thoraxe/training/blob/training-setup/setup-training.sh

This is a really ugly hack-job somewhat inspired by Urchin. I would have loved to have each function be a script that was automatically run. Basically I'm just executing the functions until one of them fails. If it fails, we exit immediately and do not continue.

My bash-fu is not good enough to try to hack at it myself, otherwise I would gladly submit a PR.

@tlevine
Copy link
Owner

tlevine commented Aug 13, 2015

Oh neat. We could add a flag that completely disables test reporting
(because I don't think you care about that) and just runs all of the
files. Did I get that right?

On 12 Aug 18:44, Erik M Jacobs wrote:

Thanks for the feedback. Here's an example of what I'm doing, kinda sorta:

https://github.com/thoraxe/training/blob/training-setup/setup-training.sh

This is a really ugly hack-job somewhat inspired by Urchin. I would have loved to have each function be a script that was automatically run. Basically I'm just executing the functions until one of them fails. If it fails, we exit immediately and do not continue.

My bash-fu is not good enough to try to hack at it myself, otherwise I would gladly submit a PR.


Reply to this email directly or view it on GitHub:
#16 (comment)

@thoraxe
Copy link
Author

thoraxe commented Aug 13, 2015

I mean, the reporting would be nice, but it's not necessarily required.

I just like the colored checks and xs :)

@tlevine
Copy link
Owner

tlevine commented Apr 4, 2016

This is part of Urchin now.

@tlevine tlevine closed this as completed Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants