Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sitemap_file as a global option #1049

Merged
merged 3 commits into from
Aug 18, 2023
Merged

add sitemap_file as a global option #1049

merged 3 commits into from
Aug 18, 2023

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Aug 17, 2023

@mortenpi would you mind trying this out?

closes #1047 by adding a global variable sitemap_file if the user wants something else than sitemap(.xml).

config.md

+++
# ... rest
sitemap_file = "mySitemap"
# ... rest
+++

--> mySitemap.xml will be generated (instead of default sitemap.xml)

@mortenpi
Copy link

Yep, this is perfect! Thank you!

Just as some bikeshedding: the option could also be called sitemap_filename maybe, to make it clear that it should not be a path?

@tlienart
Copy link
Owner Author

Agreed, in the next version there are aliases for default variables which makes that stuff a bit easier (just add more aliases!) but agreed that filename is better, will add.

@tlienart
Copy link
Owner Author

added sitemap_filename and rss_filename as aliases for sitemap_file and rss_file. will merge now, thanks for the FR!

@tlienart tlienart merged commit 7cdbba6 into master Aug 18, 2023
1 check passed
@tlienart tlienart deleted the tl/i1047 branch August 18, 2023 11:55
@mortenpi
Copy link

Thank you for implementing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to set sitemap filename
2 participants