Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation based on p-value or abs(mean) unrealistically good #5

Closed
tlnagy opened this issue Apr 28, 2016 · 3 comments
Closed

Separation based on p-value or abs(mean) unrealistically good #5

tlnagy opened this issue Apr 28, 2016 · 3 comments

Comments

@tlnagy
Copy link
Owner

tlnagy commented Apr 28, 2016

Even with the new method introduced in f25e71e of sampling an "observed phenotype" from a Normal distribution centered at the "theoretical phenotype" with a stddev of 0.5, the separation is unrealistically good. Here I'm sorting guides based on their "observed phenotype" and taking the bottom 1/3 and putting it in one bin and the top 1/3 in another and comparing:

Distribution of "observed phenotypes" that was used to bin

distributions_of_observed_phenotypes

Log-log plot of guide frequencies in the two bins

freq_scatter

Volcano plot

It's super apparent when I collapse the results down to the gene-level:

volcano_plot_by_class

What do you think @martinkampmann? I'm ending up with AUROC's of 0.999.

tlnagy added a commit that referenced this issue Apr 30, 2016
Working towards a solution to #5. Dropping the coverage of library
introduced a couple artifacts due to guides being absent starting at the
transfection state.
@tlnagy
Copy link
Owner Author

tlnagy commented Apr 30, 2016

Dropping coverage from 1000x to 100x and increasing the variance due to sorting to 1 gives the following plots...

Observed Phenotypes

distributions_of_observed_phenotypes

Volcano plot

volcano_plot_by_class

It's interesting to note that there seem to be binning occuring when pvalue -> 0

Roc

roc

tlnagy added a commit that referenced this issue Apr 30, 2016
@tlnagy
Copy link
Owner Author

tlnagy commented Apr 30, 2016

@martinkampmann Plotting the ROC curves separately for linear and sigmoidal genes:

This is with 100x and sigma=1

roc

@tlnagy
Copy link
Owner Author

tlnagy commented May 6, 2016

AUROC's for optimum screen conditions are good, but I can effectively degrade them so I'm going to go ahead and close this issue for now.

@tlnagy tlnagy closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant