respond comments at #13 (review)

tlnagy · Oct 3, 2022 · abbea48 · abbea48
1 parent 62fa8ff
commit abbea48
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -3,7 +3,6 @@ uuid = "d76558cf-badf-52d4-a17e-381ab0b0d937"
 version = "0.1.6"
 
 [deps]
-CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
 FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
 Revise = "295af30f-e4ad-537b-8983-00126c2a3abe"
 Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

diff --git a/src/parse.jl b/src/parse.jl
@@ -1,5 +1,4 @@
 function parse_header(io)
-    @debug "in parse_header for FCS"
     seekstart(io)
     rawversion = Array{UInt8}(undef, 6)
     read!(io, rawversion)
@@ -20,8 +19,11 @@ function parse_header(io)
         # the last two numbers are for the analysis segment
         # the analysis segment is facultative, although the bytes should
         # always be there
+        # (FCS 3.1 ref at https://isac-net.org/page/Data-Standards)
         # some cytometers (BD Accuri) do not put the last two bytes
         # putting "0" bytes in their files is what other cytometers do
+        # see github discussion:
+        # https://github.com/tlnagy/FCSFiles.jl/pull/13#discussion_r985251676
         if isempty(lstrip(offsets_str)) && i>4
             offsets_str="0"
         end

diff --git a/test/Project.toml b/test/Project.toml
@@ -1,4 +1,3 @@
 [deps]
 FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
-HTTP = "cd3eb016-35fb-5094-929b-558a96fad6f3"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,6 +1,6 @@
 using FCSFiles
 using FileIO
-using Test, HTTP
+using Test
 
 project_root = isfile("runtests.jl") ? abspath("..") : abspath(".")
 testdata_dir = joinpath(project_root, "test", "fcsexamples")