Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of six.b("literal") #329

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

a-detiste
Copy link
Contributor

as a side effect the program would maybe run faster

src/ecdsa/__init__.py Outdated Show resolved Hide resolved
@a-detiste
Copy link
Contributor Author

I think black makes some code better, some code worse.

I don't like it personally.

BAD:

             y_qB=int(
-                "990C57520812BE512641E47034832106BC7D3E8DD0E4C7F1136D70065"
-                "47CEC6A",
+                "990C57520812BE512641E47034832106BC7D3E8DD0E4C7F1136D70065" "47CEC6A",
                 16,
             ),
             x_Z=int(
-                "89AFC39D41D3B327814B80940B042590F96556EC91E6AE7939BCE31F3A"
-                "18BF2B",
+                "89AFC39D41D3B327814B80940B042590F96556EC91E6AE7939BCE31F3A" "18BF2B",
                 16,
             ),
             y_Z=int(
-                "49C27868F4ECA2179BFD7D59B1E3BF34C1DBDE61AE12931648F43E5963"
-                "2504DE",
+                "49C27868F4ECA2179BFD7D59B1E3BF34C1DBDE61AE12931648F43E5963" "2504DE",
                 16,
             ),

GOOD:

-            x_Z=int(
-                "312DFD98783F9FB77B9704945A73BEB6DCCBE3B65D0F967DCAB574EB", 16
-            ),
-            y_Z=int(
-                "6F800811D64114B1C48C621AB3357CF93F496E4238696A2A012B3C98", 16
-            ),
+            dA=int("7C4B7A2C8A4BAD1FBB7D79CC0955DB7C6A4660CA64CC4778159B495E", 16),
+            x_qA=int("B104A67A6F6E85E14EC1825E1539E8ECDBBF584922367DD88C6BDCF2", 16),
+            y_qA=int("46D782E7FDB5F60CD8404301AC5949C58EDB26BC68BA07695B750A94", 16),
+            dB=int("63976D4AAE6CD0F6DD18DEFEF55D96569D0507C03E74D6486FFA28FB", 16),
         )

@a-detiste
Copy link
Contributor Author

(I had also fixed 2 duplicates of sys that pyflakes complained about)

@tomato42
Copy link
Member

tomato42 commented Jan 6, 2024

change those lines so that they're not two separate strings?

change from ...F1136D70065" "47CEC6A", to ...F1136D7006547CEC6A",?

@tomato42
Copy link
Member

tomato42 commented Jan 8, 2024

use tox -e codeformat to reformat according to project's black configuration, we don't use default black config

@tomato42
Copy link
Member

tomato42 commented Jan 8, 2024

Please rebase your PR on top of current master branch, then force push to the same branch as this PR is using.

Do not merge the master branch to this branch to update it.

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, not merge master

@tomato42
Copy link
Member

tomato42 commented Jan 8, 2024

looks good, thanks!

@tomato42 tomato42 merged commit a4a8acd into tlsfuzzer:master Jan 8, 2024
65 of 70 checks passed
@a-detiste
Copy link
Contributor Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants