Client ECDSA support #360
Merged
Client ECDSA support #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging d512283 into 401712c - view on LGTM.com fixed alerts:
|
tomato42
force-pushed
the
client-ecdsa-support
branch
from
d512283
to
24be2c9
Compare
|
This pull request fixes 1 alert when merging 24be2c9 into 401712c - view on LGTM.com fixed alerts:
|
tomato42
force-pushed
the
client-ecdsa-support
branch
3 times, most recently
from
42147dd
to
0d7f252
Compare
nmav
reviewed
Oct 1, 2019
nmav
previously approved these changes
Oct 1, 2019
tomato42
force-pushed
the
client-ecdsa-support
branch
2 times, most recently
from
1668165
to
b1c9017
Compare
tomato42
force-pushed
the
client-ecdsa-support
branch
from
b1c9017
to
73e758b
Compare
|
@nmav updated |
nmav
approved these changes
Oct 3, 2019
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for client certificates with ECDSA keys
depends on: #359
(second part of the full ECDSA support, #52, reworking of #196 to make review easier)
This change is