Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for boringssl #290

Merged
merged 71 commits into from
Mar 29, 2024
Merged

Support for boringssl #290

merged 71 commits into from
Mar 29, 2024

Conversation

aeyno
Copy link
Collaborator

@aeyno aeyno commented Nov 24, 2023 •
edited
Loading

Adding support for BoringSSL PUT

aeyno and others added 28 commits November 7, 2023 16:58
@aeyno
update bindgen to 0.69.1
8dbc13f
@maxammann
Merge branch 'main' into update_bindgen
08ce9da
@aeyno
crates to build and bind boringssl
4c530d6
@aeyno
cleaning + doc
babc29d
@aeyno
add missing dependency
0008af8
@aeyno
WIP boringssl integration
0336b2b
@aeyno
freezing boringssl to a specific commit
c96340c
@aeyno
fixing regression while building boringssl
4f97f9d
@aeyno
merging update_bindgen. fixes boringssl w/ asan
720c458
@aeyno
changing source directory for boringssl
f487162
@aeyno
Merge remote-tracking branch 'origin_puffin/main' into boringssl
c685bf9
@aeyno
fix problem while cloning boringssl repo
182feb3
@LCBH
openssl deterministic test fails
822114c
@LCBH
openssl deterministic test fails
1d42a4f
@aeyno
adding client_attacker_boring trace which performs a handshake with b…
57366a0 
…oringssl
@LCBH
New determinism architecture:
aa340e5 
 - distinguish re-set RAND from reseed
 - reset RAND once for all for all factories with `determinism_set_reseed_all_factories`
 - reseed all factories before executing a trace with `determinism_reseed_all_factories`
 --> New integration test for determinsim. Passes for OpenSSL!
@LCBH
rustfmt pass
8f1ce59
@LCBH
missing dummy implems
bbbce3d
@LCBH
[det test] testing for many traces -->fails
b1cdbbb
@LCBH
trying to better reseed, still failing test
8c2e05e
@LCBH
add attempt at patching OpenSSL312 to have deterministic timestamps
5f6e43c
@aeyno
merging openssl-det
2aa4fe0
@aeyno
improving boringssl build and add randomness test (no working now)
c2b1758
@aeyno
adding git repo link to BoringSSLOptions
7cf65c7
@aeyno
adding patches to reset boringssl randomness
d531d5e
@aeyno
forgot adding boring repo url
126a71d
@aeyno
adding transcrit extraction + fixing bugs
e43d6c4
@aeyno
removing debug print
07bc293
@LCBH LCBH mentioned this pull request Feb 2, 2024
Merged
@LCBH LCBH self-requested a review March 27, 2024 12:13
LCBH
LCBH approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@LCBH LCBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

maxammann
maxammann requested changes Mar 27, 2024
View reviewed changes
crates/boring/test/rsa-encrypted.pem Outdated Show resolved Hide resolved
crates/boringssl-src/patches/reset_drbg.patch Show resolved Hide resolved
crates/boringssl-src/wrapper.h Outdated Show resolved Hide resolved
tlspuffin/src/wolfssl/mod.rs Show resolved Hide resolved
tlspuffin/src/tls/seeds.rs Outdated Show resolved Hide resolved
tlspuffin/src/integration_tests/determinism.rs Show resolved Hide resolved
tlspuffin/src/integration_tests/determinism.rs Show resolved Hide resolved
tlspuffin/src/openssl/deterministic.rs Outdated Show resolved Hide resolved
tlspuffin/src/tls/fn_utils.rs Show resolved Hide resolved
tlspuffin/src/tls/rustls/msgs/message.rs Show resolved Hide resolved
@LCBH LCBH linked an issue Mar 29, 2024 that may be closed by this pull request
tlspufifn is broken #251
Closed
@LCBH LCBH requested a review from maxammann March 29, 2024 13:19
@LCBH
Copy link
Contributor

LCBH commented Mar 29, 2024

Good to merge 👍

@aeyno aeyno mentioned this pull request Mar 29, 2024
Open
4 tasks
@LCBH LCBH merged commit 310bb2f into main Mar 29, 2024
16 checks passed
@LCBH LCBH deleted the boringssl branch March 29, 2024 14:07
@michaelmera michaelmera mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LCBH LCBH LCBH approved these changes

@michaelmera michaelmera michaelmera approved these changes

@maxammann maxammann Awaiting requested review from maxammann

Assignees

@aeyno aeyno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tlspufifn is broken
4 participants
@aeyno @LCBH @maxammann @michaelmera