-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl deterministic test fails #293
Conversation
- distinguish re-set RAND from reseed - reset RAND once for all for all factories with `determinism_set_reseed_all_factories` - reseed all factories before executing a trace with `determinism_reseed_all_factories` --> New integration test for determinsim. Passes for OpenSSL!
Commit #aa340 fixed the issue:
The test |
The test is actually not really reproducible. b1cdbbb is doing the same on multiple traces and it fails at some point :( |
Conclusion: this test fails because of session tickets sent after the final Server FInishes. Those contain time-related information, which thus differ across executions. In BoringSSL, the flag |
Will close without merging, the useful more complete deterministic uni test is also in #290 that will me merged. |
PartialEq
andDebug
forTraceContext
so that we can compare the twoTraceContext
obtained at different times from executing the same trace.client_attacker_full
.openssl::deterministic::tests::test_openssl_no_randomness_full
.