Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require RFC6979 deterministic ECDSA #406

Closed
wants to merge 3 commits into from
Closed

Require RFC6979 deterministic ECDSA #406

wants to merge 3 commits into from

Conversation

ctz
Copy link
Contributor

@ctz ctz commented Jan 23, 2016

I think TLS1.3 should require implementations to use RFC6979 deterministic ECDSA. This eradicates the well-known flaw in ECDSA, and makes ECDSA k selection testable for correctness.

@davegarrett
Copy link
Contributor

I get the feeling from discussion on the mailing list that the WG is leaning towards consensus for a "SHOULD" not a "MUST", as this is an unverifiable & unenforceable requirement, and systems with true RNGs can actually do things properly. I suggest changing this PR to reflect this, including leaving the pitfalls section as it is in the current draft.

Mentioning TRNGs could be a good idea here, to differentiate that case from when doing things deterministically his highly preferred. e.g., something to the effect of:

"ECDSA signatures SHOULD be deterministically made using the scheme specified in {{RFC6979}} or generated using randomness provided by a secure hardware entropy source."

(not sure of the best way to word this)

A squash of all commits might also be a good idea.

@ctz
Copy link
Contributor Author

ctz commented Jan 25, 2016

This PR is superseded by #408

@ctz ctz closed this Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants