Recommend RFC6979 deterministic ECDSA #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -796,7 +797,9 @@ of the digest output. Note that previous versions of TLS used RSASSA-PKCS1-v1_5, | |||
| not RSASSA-PSS. | |||
|
|
|||
| All ECDSA computations MUST be performed according to ANSI X9.62 {{X962}} | |||
| or its successors. Data to be signed/verified is hashed, and the | |||
| or its successors. The utmost care must be taken to choose high-entropy | |||
| "k" values; use of {{RFC6979}} Deterministic ECDSA is RECOMMENDED to ensure this. | |||
There was a problem hiding this comment.
put the name before the ref ("Deterministic ECDSA {{RFC6979}}" instead of above)
There was a problem hiding this comment.
done in 2b59c72, cheers!
In the signing details section, we warn and then recommend RFC6979. In the crypto pitfalls section, reiterate and try to impress the importance of getting this right.
| countermeasure is described in {{RFC6979}}. | ||
| The impact of a failure here is key material disclosure, and in TLS the | ||
| keys involved are typically high value: long-term, externally certified | ||
| and the root of endpoint authentication. |
There was a problem hiding this comment.
These last 3 lines should probably be cut, as this is a bit long and overly redundant.
Also, the other bullet points are in the form of a question, and this isn't (just a nitpick, though).
ekr
added a commit
that referenced
this pull request
Jul 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the signing details section, we warn and then recommend
RFC6979.
In the crypto pitfalls section, reiterate and try
to impress the importance of getting this right.