Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learner CARET #240

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Learner CARET #240

merged 4 commits into from
Oct 4, 2019

Conversation

yulun-rayn
Copy link
Contributor

This PR added Lrnr_caret with doc and test, built upon package caret. Fixed minor formatting. #114

@yulun-rayn
Copy link
Contributor Author

previous commit history and comments #236

@nhejazi
Copy link
Member

nhejazi commented Oct 4, 2019

As with #241, the CI build failures are not due to any issue introduced here. I've confirmed that checks/tests pass on my local machine, going ahead with merging based on this. The changes look good to me, thanks for your PR!

@nhejazi nhejazi merged commit 68b7ad6 into tlverse:devel Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants