Fix docker builds #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Getzen <charlie.getzen@procore.com>
cgetzen
force-pushed
the
cg/fix_dockerfile
branch
from
448c72d
to
7dc9bae
Compare
nviennot
force-pushed
the
master
branch
2 times, most recently
from
bb1e470
to
4555d8d
Compare
|
Should be good now. Docker image is also uploaded here: https://hub.docker.com/r/tmate/tmate-ssh-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewind libssh to earliest introduction of SSH_BIND_OPTIONS_IMPORT_KEY instead of cloning from a stale tag.
libssh-0.7.x - doesn't have SSH_BIND_OPTIONS_IMPORT_KEY
libssh-0.8.x - has a cmake dependency
proof of build: https://cloud.docker.com/repository/registry-1.docker.io/cgetzen/tmate-slave/builds/3b352e83-f73d-4ea5-8eed-957cd1a43f5b
proof of previous failure: https://cloud.docker.com/repository/docker/cgetzen/tmate-slave/builds/d1e6c439-06c3-4a82-88e5-ac1f39bad60f
follow up issue #55.