Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker config is invalid #142

Merged
merged 1 commit into from Feb 19, 2016
Merged

Docker config is invalid #142

merged 1 commit into from Feb 19, 2016

Conversation

rlaveycal
Copy link
Contributor

Docker (at least, v1.9.1) requires that values in the config file are enclosed in quotes. The current code doesn't do this, resulting in a corrupt file that prevents docker from starting.

@otahi
Copy link
Collaborator

otahi commented Feb 11, 2016

@rlaveycal I am very very appreciated to your pull request!!

I have checked docker documentation moby/moby@d53b586 . And it seems that double quotations are required for http_proxy environment variables at least docker 1.4.

I could not found any change around http_proxy environment. Can you give some information about docker's change?

I want to check the issue in my environment, please give some information how you reproduce the issue(OS, version, and more).

@rlaveycal
Copy link
Contributor Author

I'm using Ubuntu 14.04 (trusty) with Docker 1.9.1. I'm not a linux/docker person, just using it for an eval project so just going by the comment in the default file.

@otahi
Copy link
Collaborator

otahi commented Feb 15, 2016

@rlaveycal
I have checked http_proxy environment variables on Ubuntu 14.04 (trusty) with Docker 1.10.1(Installation).
It seems docker works with environment variables.

I want to confirm that you have no trouble on your environment and just want to fix the requirement violation. Is it right?

@rlaveycal
Copy link
Contributor Author

Yes, Once I enclose the values in double quotes in the docker file everything works. Without them docker won't start.

@otahi
Copy link
Collaborator

otahi commented Feb 19, 2016

I have checked it works on my environment.
Thank you for your pull request!

otahi added a commit that referenced this pull request Feb 19, 2016
@otahi otahi merged commit b9d6024 into tmatilai:master Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants