Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llm-openai-client: openai base url option #117

Merged
merged 3 commits into from
Jun 10, 2023
Merged

llm-openai-client: openai base url option #117

merged 3 commits into from
Jun 10, 2023

Conversation

swuecho
Copy link
Contributor

@swuecho swuecho commented Jun 7, 2023 •
edited

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Describes source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.
  • (remove and do not use this row unless you are a trusted contributor) I am an existing
    contributor.

@swuecho swuecho mentioned this pull request Jun 8, 2023
Open
tmc
tmc approved these changes Jun 10, 2023
View reviewed changes
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@tmc tmc merged commit b28f2f1 into tmc:main Jun 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swuecho @tmc