Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve code qualities and use idiomatic way to implementation #27

Merged
merged 1 commit into from
Apr 19, 2023
Merged

chore: improve code qualities and use idiomatic way to implementation #27

merged 1 commit into from
Apr 19, 2023

Conversation

nekomeowww
Copy link
Contributor

Description

Improvements of #18

  • Removed unnecessary code
  • Use http.StatusXxx instead of hardcoded numbers when checking http status
  • Replaced incorrect use of fmt.Printf(..) with log.Printf(...) with idiomatic prefixes [WARN]
  • Replaced incorrect use and deprecated ioutil.ReadAll(...) with *bytes.Buffer and io.Copy(...) for better performance

@tmc
Copy link
Owner

tmc commented Apr 19, 2023

LGTM

@tmc tmc merged commit e756c2f into tmc:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants