Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: configure theme #164

Merged
merged 2 commits into from
Jul 31, 2018
Merged

compose: configure theme #164

merged 2 commits into from
Jul 31, 2018

Conversation

delvedor
Copy link
Contributor

@delvedor delvedor commented Jul 30, 2018

As titled! :)

Usage:

# default is 'light'
big-presentation-compose -t dark
big-presentation-compose --theme dark

Thank you for the project!

@tmcw
Copy link
Owner

tmcw commented Jul 30, 2018

👍 A few thoughts:

  • Maybe mention this in the protips.md documentation?
  • Should the CLI support --help if it's going to have options? Ideally this is a discoverable command.

@delvedor
Copy link
Contributor Author

Thank you for reviewing this!

Maybe mention this in the protips.md documentation?

Totaly agree!

Should the CLI support --help if it's going to have options? Ideally this is a discoverable command.

Since currently the cli supports just one command I think update the protips.md is enough, but for the future could definitely be a thing to do if you might want to add more commands.

@tmcw
Copy link
Owner

tmcw commented Jul 31, 2018

Thanks!

@tmcw tmcw merged commit 8435450 into tmcw:gh-pages Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants