Add per-slide body classes from data attribute #32
Conversation
|
Hm, interesting. I can see the use case but am not sure that this is the right way to do it: could we instead assign a |
|
@TMWC I've done that approach before, but what ends up happening is you end up with a slew of classes that have no inherent meaning. slide-1 doesn't tell me that it relates to my CouchDB title slide. Some of my personal use cases: |
|
I'm also using Big for a few presentations for a conference I'm speaking at next week. It's prime for that because of the auto-sizing. |
|
Related to your comment, it also makes it more difficult to rearrange slides during presentation buildout. Given that you developed this I'm sure you've spoken quite a lot. I do too and I'm rearranging slides up to the last minute before presentations. |
| document.body.className = e.dataset['bodyclass']; | ||
| } else { | ||
| document.body.className = ''; | ||
| } |
There was a problem hiding this comment.
This could possibly be golfed down a bit?
document.body.className = e.dataset.bodyclass || '';There was a problem hiding this comment.
Yeah, I actually had it smaller. Then I lost my nerve and backed it out. Wanted to make it easier for ppl reading source. But your option would be more ideal.
| @@ -4,6 +4,8 @@ window.onload = function() { | |||
| function go(n) { | |||
| cur = n; | |||
| var i = 1e3, e = s[n], t; | |||
| // if the div has a bodyclass data attribute, add it to the body | |||
| document.body.className = e.dataset['bodyclass'] || ''; | |||
There was a problem hiding this comment.
Is there any reason not to say e.dataset.bodyclass here?
There was a problem hiding this comment.
I don't believe so. Let me test. Nope. Looks good.
|
👍 looks good, merging! |
Add per-slide body classes from data attribute
|
Nice! Thanks for working with me on this. Appreciate your time, and love the lib. It's my go-to one now. |
Update big.js to tmcw/big#32
My team has been using Big for our sprint demo slidedeck for a few months now. We added a simple option to add custom body classes on a per slide basis.
Committing this back to make sure we don't lose this option when we upgrade.