Skip to content

Commit

Permalink
Disable GenerateSatelliteAssemblies target
Browse files Browse the repository at this point in the history
The standard `GenerateSatelliteAssemblies` target that ships with MSBuild uses al.exe (alink) to create satellite assemblies. However, there are a couple of things it doesn't support that we need in the dotnet/roslyn repo--see issues dotnet#23190 and dotnet#23191 for details. Instead, we want to use the `CoreGenerateSatelliteAssemblies` target from Microsoft.NET.Sdk. We've already opted in to that target, and now we need to opt out of the original `GenerateSatelliteAssemblies`. Until we can move to a copy of MSBuild that includes the change in dotnet/msbuild#2726 the best way to do that is to redefine the target as a no-op.
  • Loading branch information
tmeschter committed Dec 5, 2017
1 parent 3669d04 commit 5f8750c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions build/Targets/Imports.targets
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,13 @@
</_ResourcesToMergeWithCTOWithCultureMetadata>
</ItemGroup>
</Target>

<!--
Workaround until we can move to a version of MSBuild that includes the change in https://github.com/Microsoft/msbuild/pull/2726.
We want to opt into the Microsoft.NET.Sdk approach to generating satellite assemblies, which means we also need to opt out of
default approach. We do this by turning GenerateSatelliteAssemblies into a no-op.
-->
<Target Name="GenerateSatelliteAssemblies" />

<ImportGroup Condition="'$(ImportVSSDKTargets)' == 'true'">
<Import Project="$(NuGetPackageRoot)\Microsoft.VSSDK.BuildTools\$(VisualStudioBuildToolsVersion)\build\Microsoft.VsSDK.BuildTools.targets" />
Expand Down

0 comments on commit 5f8750c

Please sign in to comment.