Fix conversion from long long to int causing truncation. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmewett
approved these changes
Jul 3, 2021
The error I got verbatim was:
src/brogue/Items.c:3353:23: warning: absolute value function 'abs' given an argument of type 'fixpt' (aka 'long long') but has parameter of type 'int' which may cause truncation of value
[-Wabsolute-value]
fixpt m = max(abs(step[0]), abs(step[1]));
^
src/brogue/Items.c:3353:23: note: use function 'llabs' instead
fixpt m = max(abs(step[0]), abs(step[1]));
^~~
llabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue by using
llabs()instead ofabs()following the suggestion given by the compiler but maybe you do not want to use C99 standard (llabsis available since C99 only).The warning I got was: