Puma middleware #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I didn't know about this after reply trick. Is it only implemented in Puma? |
|
Yes, looks like it's Puma-only thing. |
|
I'm not sure this makes sense in a threaded environment. Wouldn't the OOBGC be triggered concurrently (and needlessly) under load? Even on a lightly loaded system, the OOBGC will run while other requests are being processed which defeats the purpose. |
|
Good point. The way oobgc works is by measuring the number of allocations between calls to |
|
Ok, this is what I was afraid of. Is there any workarounds or different schemes that can be applied? |
|
Reverted for now. I'm not sure how OOBGC should work in this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent middleware for Puma server.