Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Crash if terminal width is less than 141 columns #12

Closed
tmplt opened this issue Aug 5, 2017 · 0 comments
Closed

Crash if terminal width is less than 141 columns #12

tmplt opened this issue Aug 5, 2017 · 0 comments
Labels

Comments

@tmplt
Copy link
Owner

tmplt commented Aug 5, 2017

The crash is caused by the x-assert in screen::base::change_cell(), so we obviously start looking there.

@tmplt tmplt added the bug label Aug 5, 2017
@tmplt tmplt changed the title Crash if terminal width is less than 140 columns Crash if terminal width is less than 141 columns Aug 6, 2017
tmplt added a commit that referenced this issue Aug 6, 2017
Alright, multiselect_menu is pretty shit. Not only does it _not_ use the
full width to our advantage, it sometimes writes outside of it's allotted
cells (a heinous crime).

First in order should be to rewrite multiselect_menu to remedy this, but
I've gotten quite burned out on TUI code for the time being. Future me
will take care of it, I'm sure.

I also cannot help the feeling that termbox is acting up: if I resize
the window the last column will some times be written out even though
it obviously wont fit. But that's probably just the can-we-fit-it-check
acting up.
@tmplt tmplt closed this as completed in 0a546e9 Aug 6, 2017
tmplt added a commit that referenced this issue Aug 26, 2018
Instead of accessing wanted authors via

    wanted.nonexacts.authors

this field (along with the rest) can not be accessed via

    wanted.authors

This behavior should be tested.

Related to #12.
tmplt added a commit that referenced this issue Aug 26, 2018
Instead of

    bookwyrm.log(pybookwyrm.log_level.debug, 'this is a debug log entry')

entries can now be logged as

    bookwyrm.log.debug('this is a debug log entry')

Closes #12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant