Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

screens/item_details: implement resizing #13

Open
tmplt opened this issue Aug 5, 2017 · 2 comments
Open

screens/item_details: implement resizing #13

tmplt opened this issue Aug 5, 2017 · 2 comments
Labels
enhancement low prio tui this issue regards the text-based user-interface

Comments

@tmplt
Copy link
Owner

tmplt commented Aug 5, 2017 •
edited

Just alike multiselect_menu::on_resize(). This way the user does not have to reopen an item_details screen after a resize event.
@tmplt tmplt added this to the v1.0.0 milestone Aug 5, 2017
@tmplt
Copy link
Owner Author

tmplt commented Aug 5, 2017 •
edited

#12 should be tackled first.

EDIT: done.

tmplt added a commit that referenced this issue Aug 13, 2017
@tmplt
butler/screen: close details on resize event
b8fb77b 
I'm not sure how #13 should be approached since its height is 80% of
the index menu pre-compression. One way would be to close the detail
screen and recalculate the height. While "expensive", it's probably the
easiest way.
@tmplt
Copy link
Owner Author

tmplt commented Sep 25, 2017

For a resize, we'd need to know the size of the index menu. This would (and should only) be possible to know if we query the screen butler, but implementing this would be another two-way communication shoved in there just there for such a small thing.

@tmplt tmplt removed this from the v1.0.0 milestone Sep 25, 2017
@tmplt tmplt changed the title Allow item_details to resize screens/item_details: implement resizing Oct 25, 2017
@tmplt tmplt added the low prio label Oct 25, 2017
@tmplt tmplt added the tui this issue regards the text-based user-interface label Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement low prio tui this issue regards the text-based user-interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmplt