Add --log-file option to load command

[joseph-flinn]

Adding the --log-file option to the load command.

(As discussed over email. There isn't a specific issue for the addition)

[codecov]

Codecov Report

Merging #647 (287fcc1) into v1.6.x (8858179) will increase coverage by 0.36%.
The diff coverage is 46.42%.

@@            Coverage Diff             @@
##           v1.6.x     #647      +/-   ##
==========================================
+ Coverage   73.83%   74.19%   +0.36%     
==========================================
  Files           7        7              
  Lines        1055     1062       +7     
  Branches      269      271       +2     
==========================================
+ Hits          779      788       +9     
+ Misses        202      200       -2     
  Partials       74       74              

Impacted Files	Coverage Δ
tmuxp/cli.py	71.60% <46.42%> (+1.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8858179...287fcc1. Read the comment docs.

[tony]

Nice @joseph-flinn !

The logger does such a good job it preserves colors:

tmuxp load ~/work/python/libtmux --log-file ~/mylog.log

In another tab:

cat mylog.log

~ ❯ cat mylog.log
(INFO) [15:11:15] tmuxp.cli  [Loading] /home/t/work/python/libtmux/.tmuxp.yaml

1. Should we add an ability to control log level? I don't think one is available is it?
2. Should we add an option to stripe formatting?

cat looks beautiful, but for the text itself in an editor:

^[[0m^[[32m^[[1m(INFO)^[[0m [^[[30m^[[2m^[[1m15:11:15^[[39m^[[0m] ^[[37m^[[2m^[[1mtmuxp.cli^[[39m^[[0m ^[[0m [Loading] /home/t/work/python/libtmux/.tmuxp.yaml

[joseph-flinn]

1. I think there is a way to set the log level from the click.group by including --log_level <LEVEL> before the load command. This should be passed through to tmuxp_echo. I did just notice that --log_level uses underscores (left over from all of the other logging code I assume). I'll change that over to a dash.
2. Hmm...I click.unstyled the message before logging it to the file. I wonder if the logger formatter that was already included with tmuxp has some coloring that is left over. We probably don't want the color if it is leaving the (bash?) color codes. Or if we want to give the option for coloring the log file, I think it should be an additional option but defaults to no color. Thoughts?

I also just remembered that I forgot to update the README and other supporting documentation. I'll go ahead and do that as well

[tony]

@joseph-flinn Sorry for the delay! I may be busy on the weekend for a week or two (errands on my end!)

Merged in v1.6.3 and v1.7.0a3!

1.6.3: http://localhost:8031/history.html#tmuxp-1-6-3-2020-11-22, https://pypi.org/project/tmuxp/1.6.3/

1.7.0a3: http://localhost:8031/history.html#tmuxp-1-7-0a3-2020-11-22, https://pypi.org/project/tmuxp/1.7.0a3/

[joseph-flinn]

No worries! I'll probably be a bit busy for the next couple weekends as well, but will put some work in when I can.

…

On Sun, Nov 22, 2020, 12:37 Tony Narlock ***@***.***> wrote: @joseph-flinn <https://github.com/joseph-flinn> Sorry for the delay! I may be busy on the weekend for a week or two (errands on my end!) Merged in v1.6.3 and v1.7.0a3! 1.6.3: http://localhost:8031/history.html#tmuxp-1-6-3-2020-11-22, https://pypi.org/project/tmuxp/1.6.3/ 1.7.0a3: http://localhost:8031/history.html#tmuxp-1-7-0a3-2020-11-22, https://pypi.org/project/tmuxp/1.7.0a3/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#647 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN5KNNOKMJQOYWFQXTYBWSDSRFY7RANCNFSM4TWL7PUA> .

[tony]

@joseph-flinn Sounds good!