Add the ability to append windows to a session #656
Conversation
Modifies the behaviour when starting a session from within an existing tmux session: the user is given the choice to switch to new session, do nothing, or append to current session.
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 76.18% 75.93% -0.25%
==========================================
Files 8 8
Lines 1142 1180 +38
Branches 286 295 +9
==========================================
+ Hits 870 896 +26
- Misses 196 204 +8
- Partials 76 80 +4
Continue to review full report at Codecov.
|
|
@tony this PR is hopefully what you were asking for in this comment - let me know if any further changes are needed 👍 |
| All of these options can be preselected to skip the prompt: | ||
|
|
||
| .. code-block:: bash | ||
| $ tmuxp load -y config # load attached |
There was a problem hiding this comment.
In tmux lore, typically -a is reserved for attaching.
Is there any other posix / unix-like apps that have another arg they use to mean append? (Not a requirement of course)
There was a problem hiding this comment.
I'm looking through this PR as a whole, and -a / (a)ppend seems to make the most sense and "fit" the best to me. Nice
There was a problem hiding this comment.
Impressive! Works very well.
Let's keep the __version__ as-is for now (0660049). This way when 1.7.0 is final / gold, appending will be there with our plugin system.
Go ahead and merge when you're ready.
(I will aim to release this as part of 1.7.0 this weekend)
|
Great! I don't have permission to merge so if anyone does, go for it. Thanks for the quick approval! |
Check your email for an invite. |
|
Nothing in my inbox, and I can't join via the direct link (as described here) - would you be able to resend the invite? |
|
@will-ockmore Resent It's an email from GitHub, so you need to check the email on your account Maybe you'll see invites in the org itself? https://github.com/tmux-python/ https://github.com/orgs/tmux-python/invitation Let me know if it's any better, if that doesn't work, email me! (my email is on my profile) |
|
p.s. @will-ockmore Also be sure you're checking your personal GH account and not an alternate / work one, if there is one |
|
Got the org invite, thanks! No idea why the repo invite didn't work 🤷♂️ |
|
@will-ockmore This is live https://pypi.org/project/tmuxp/1.7.0/ https://tmuxp.git-pull.com/history.html#tmuxp-1-7-0-2021-01-09 How's it workin? (If there's any quirks we can iron them out in patch releases, if not, that's good too. In either event, job well done!) |
|
Installed and been using it today - seems to be working great. Thanks for cutting the release, let me know if there are any problems you find - will keep an eye out over the next week and see if I can find any bugs! |
|
@will-ockmore Awesome! Excited to have this and @joseph-flinn's Plugin system and debugging updates live! |
Based off of the work already submitted in #501. Unfortunately I wasn't able to rebase the commits cleanly as it was too far diverged from master. All credit for the idea and structure should go to @emanuelhfarias 👏
All I've added is a bit of code cleanup, and a bugfix regarding the behaviour of appending windows to a session when there is more than one attached.
Quoted below is the original PR description:
My motivation is much the same - I like to use sessions to organise different groups of projects, and within those each project will use one or more windows. I find switching between windows more intuitive and prefer the extra organisation choices this method gives me!