Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking freeze ux flow #657

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Tweaking freeze ux flow #657

merged 3 commits into from
Feb 22, 2022

Conversation

joseph-flinn
Copy link
Contributor

Rewording a line/question in the freeze command.

Original:

Freeze does it best to snapshot live tmux sessions.

The new config *WILL* require adjusting afterwards. Save config? [y/N]: y
Save to: /home/user/.tmuxp/test.yaml [/home/user/.tmuxp/test.yaml]: 
Save to /home/user/.tmuxp/test.yaml? [y/N]: y
Saved to /home/user/.tmuxp/test.yaml.

New:

Freeze does it best to snapshot live tmux sessions.

The new config *WILL* require adjusting afterwards. Save config? [y/N]: y
Path to new config: [/home/user/.tmuxp/test.yaml]: 
Save to /home/user/.tmuxp/test.yaml? [y/N]: y
Saved to /home/user/.tmuxp/test.yaml.

I have also been caught by this once when moving through the workflow really quickly. I think changing the second line to something other than Save to and removing the first default path would slightly improve the flow. That being said, I am not tied to the chosen language used what-so-ever.

Issue: #627

@joseph-flinn joseph-flinn requested a review from tony January 9, 2021 16:20
@joseph-flinn joseph-flinn changed the title Tweaking freeze uxflow Tweaking freeze ux flow Jan 17, 2021
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #657 (4f6d855) into master (97cb0a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files           7        7           
  Lines        1179     1179           
  Branches      306      306           
=======================================
  Hits          895      895           
  Misses        201      201           
  Partials       83       83           
Impacted Files Coverage Δ
tmuxp/cli.py 73.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cb0a7...4f6d855. Read the comment docs.

@tony
Copy link
Member

tony commented Feb 22, 2022

Edit: Nevermind, this looks good to go in

@joseph-flinn Can this get a rebase?

@tony tony merged commit 491576f into master Feb 22, 2022
@tony tony deleted the jf-tweaking-freeze-uxflow branch February 22, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants