Pass start_directory to new_session when building a session #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the `start_directory` session config was no longer passed to the `new_session` method when building a session. This resulted in the session working directory is not being set correctly, so new windows/panes created in the session, would not start in the expected directory.
|
|
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 18 18
Lines 1396 1396
Branches 326 326
=======================================
Hits 1047 1047
Misses 263 263
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@heindsight Very good catch. Would you like to add anything to |
|
@tony thanks. I don't think this really needs to be mentioned in |
tony
added a commit
that referenced
this pull request
Oct 1, 2022
tony
added a commit
that referenced
this pull request
Oct 1, 2022
|
@heindsight This is live in 1.15.3 If you try it out, any better? |
|
@tony Yes, that's much better. Thanks 😃 |
|
@heindsight Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the
start_directorysession config was no longer passed to thenew_sessionmethod when building a session. This resulted in the session working directory is not being set correctly, so new windows/panes created in the session, would not start in the expected directory.