Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Aggressive ruff fixes #928

Merged
merged 2 commits into from Apr 13, 2024
Merged

chore: Aggressive ruff fixes #928

merged 2 commits into from Apr 13, 2024

Conversation

tony
Copy link
Member

@tony tony commented Apr 12, 2024

ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore F401 --ignore PT014 --ignore RUF100 --ignore PGH004; ruff format .

Fixed 8 errors:

  • docs/_ext/aafig.py:
    2 × COM812 (missing-trailing-comma)
  • src/tmuxp/cli/load.py:
    1 × PLR5501 (collapsible-else-if)
  • src/tmuxp/plugin.py:
    3 × FURB110 (if-exp-instead-of-or-operator)
  • src/tmuxp/workspace/builder.py:
    2 × COM812 (missing-trailing-comma)

Found 1243 errors (8 fixed, 1235 remaining).

ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore F401 --ignore PT014 --ignore RUF100 --ignore PGH004; ruff format .

Fixed 8 errors:
- docs/_ext/aafig.py:
    2 × COM812 (missing-trailing-comma)
- src/tmuxp/cli/load.py:
    1 × PLR5501 (collapsible-else-if)
- src/tmuxp/plugin.py:
    3 × FURB110 (if-exp-instead-of-or-operator)
- src/tmuxp/workspace/builder.py:
    2 × COM812 (missing-trailing-comma)

Found 1243 errors (8 fixed, 1235 remaining).
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (4b5518f) to head (85b982d).

❗ Current head 85b982d differs from pull request most recent head b0281c0. Consider uploading reports for the commit b0281c0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   70.19%   70.19%           
=======================================
  Files          26       26           
  Lines        1936     1936           
  Branches      404      404           
=======================================
  Hits         1359     1359           
  Misses        454      454           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony marked this pull request as ready for review April 13, 2024 00:05
@tony tony merged commit df98fce into master Apr 13, 2024
15 checks passed
@tony tony deleted the ruff-fixes branch April 13, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant