Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux -V returning "master" instead of version number #810

Closed
agrajag9 opened this issue Mar 6, 2017 · 12 comments
Closed

tmux -V returning "master" instead of version number #810

agrajag9 opened this issue Mar 6, 2017 · 12 comments

Comments

@agrajag9
Copy link

agrajag9 commented Mar 6, 2017

When compiling from source in github, PACKAGE_VERSION='master' and PACKAGE_STRING='tmux master'. This results in a compiled binary that returns tmux master to the command tmux -V instead of a useful version number. This in turn causes problems for other codebases that rely on determining tmux versions for integration (e.g. powerline).

@ThomasAdam
Copy link
Contributor

Seems this changed in c034670

@nicm
Copy link
Member

nicm commented Mar 6, 2017 via email

@agrajag9
Copy link
Author

agrajag9 commented Mar 6, 2017

Feature request: version numbering.

@nicm
Copy link
Member

nicm commented Mar 6, 2017

Releases are versioned, master is not. There is no reason that "2.4" meaning one of 2.4-release or master is any better than "2.4" meaning 2.4-release and master meaning master, and there are advantages to the latter.

@ZyX-I
Copy link

ZyX-I commented Mar 6, 2017

This is intentional, programs should not rely on the format of tmux -V.

If programs should not rely on this format how they are supposed to get tmux version? It is much more strong statement then refusing to output version number in git builds.

Also what are advantages of not showing version number on master? I think that best variant is something like v0.2.0-827-gff6fa39: this is Neovim version. Basically the output of git describe: contains last release version, number of commits since then and actually used hash. This, of course, does not work for non-VCS builds, but most of time it is good.

@nicm
Copy link
Member

nicm commented Mar 7, 2017 via email

@nicm
Copy link
Member

nicm commented Mar 7, 2017 via email

@seanspotatobusiness
Copy link

I installed tmux via some commands I found to compile from github and now my version says 'master' and I've no way of knowing what version that really is. I presume 2.7 or similar.

@AMV007
Copy link

AMV007 commented Jul 9, 2018

Ok, looking like it's dead end, so I wrote simple script to compile latest tmux locally with correct version:
https://github.com/AMV007/tmux_install

@tomskopek
Copy link

I would like to see this re-opened, tmux master is not helpful.

For example - I was just installing tmuxinator and it says it does not work in tmux 2.5.
How is one to know that they are not running 2.5?

Out of interest, at the moment, what other results could tmux -V output? Other than tmux master I mean?

@chros73
Copy link

chros73 commented Aug 8, 2018

You can easily modify it to display anything before compiling.

what other results could tmux -V output? Other than tmux master I mean?

The version number.

@lock
Copy link

lock bot commented Feb 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

8 participants