New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmux -V returning "master" instead of version number #810
Comments
Seems this changed in c034670 |
This is intentional, programs should not rely on the format of tmux -V.
On 6 Mar 2017 10:48 pm, "agrajag9" <notifications@github.com> wrote:
When compiling from source in github, PACKAGE_VERSION='master' and
PACKAGE_STRING='tmux
master'. This results in a compiled binary that returns tmux master to the
command tmux -V instead of a useful version number. This in turn causes
problems for other codebases that rely on determining tmux versions for
integration (e.g. powerline).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#810>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASkcxi9-GzOqlSavwtPgxDWfm1rYJRtks5rjI1KgaJpZM4MUzYa>
.
|
Feature request: version numbering. |
Releases are versioned, master is not. There is no reason that "2.4" meaning one of 2.4-release or master is any better than "2.4" meaning 2.4-release and master meaning master, and there are advantages to the latter. |
If programs should not rely on this format how they are supposed to get tmux version? It is much more strong statement then refusing to output version number in git builds. Also what are advantages of not showing version number on master? I think that best variant is something like |
They should not rely on the format always being the same, if they break
because tomorrow we decide to call the next version tmux 'Randy Rabbit'
2017 instead of 2.4 then it is a bug.
I don't want Git to be a build time dependency, so 'x.y' or 'master' is the
most we can do without that.
On 6 Mar 2017 11:46 pm, "Nikolai Aleksandrovich Pavlov" < notifications@github.com> wrote:
This is intentional, programs should not rely on the format of tmux -V.
If programs should not rely on this format how they are supposed to get
tmux version? It is much more strong statement then refusing to output
version number in git builds.
Also what are advantages of not showing version number on master? I think
that best variant is something like v0.2.0-827-gff6fa39: this is Neovim
version. Basically the output of git describe: contains last release
version, number of commits since then and actually used hash. This, of
course, does not work for non-VCS builds, but most of time it is good.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#810 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASkc6TB_wpOgCI78wS5gTCAxW23arHdks5rjJrEgaJpZM4MUzYa>
.
|
We could do '2.3-master' instead of plain 'master' I suppose, but I'm not
sure it is worth changing it again, it only matters if it is /some/ Git
build and not a specific release.
On 7 Mar 2017 6:11 am, "Nicholas Marriott" <nicholas.marriott@gmail.com>
wrote:
They should not rely on the format always being the same, if they break
because tomorrow we decide to call the next version tmux 'Randy Rabbit'
2017 instead of 2.4 then it is a bug.
I don't want Git to be a build time dependency, so 'x.y' or 'master' is the
most we can do without that.
On 6 Mar 2017 11:46 pm, "Nikolai Aleksandrovich Pavlov" < notifications@github.com> wrote:
This is intentional, programs should not rely on the format of tmux -V.
If programs should not rely on this format how they are supposed to get
tmux version? It is much more strong statement then refusing to output
version number in git builds.
Also what are advantages of not showing version number on master? I think
that best variant is something like v0.2.0-827-gff6fa39: this is Neovim
version. Basically the output of git describe: contains last release
version, number of commits since then and actually used hash. This, of
course, does not work for non-VCS builds, but most of time it is good.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#810 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASkc6TB_wpOgCI78wS5gTCAxW23arHdks5rjJrEgaJpZM4MUzYa>
.
|
I installed tmux via some commands I found to compile from github and now my version says 'master' and I've no way of knowing what version that really is. I presume 2.7 or similar. |
Ok, looking like it's dead end, so I wrote simple script to compile latest tmux locally with correct version: |
I would like to see this re-opened, For example - I was just installing tmuxinator and it says it does not work in tmux 2.5. Out of interest, at the moment, what other results could |
You can easily modify it to display anything before compiling.
The version number. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When compiling from source in github,
PACKAGE_VERSION='master'
andPACKAGE_STRING='tmux master'
. This results in a compiled binary that returnstmux master
to the commandtmux -V
instead of a useful version number. This in turn causes problems for other codebases that rely on determining tmux versions for integration (e.g. powerline).The text was updated successfully, but these errors were encountered: