Add git commit hash to -V option display result

[h-michael]

If the user use git command and build at directory has .git, tmux -V show git commit hash.

ex.

$ tmux -V
$ tmux next-2.9 1d6fe43c

[nicm]

No I don't want this thanks.

[h-michael]

@nicm
I'm sorry for not knowing that you don't want that.
I build tmux everyday when new commit is pushed.
But I sometimes face to regressions.
If I can know tmux's commit hash I use, I can more easily to report the issue.

Would you tell me why you don't want?

[nicm]

I don't think the build should have a dependency on the VCS and I don't think the version string should depend on where you got the code. If you are reporting problems it is best to reproduce with the latest Git anyway.

[h-michael]

I don't think the build should have a dependency on the VCS

I understand your thought.
How do you think adding patch number to each code changes ?

[nicm]

That means a lot of extra work for something that I don't see how can really be a big issue. If you are running a release, they are versioned already. If you are running master, then you should be doing git pull before reporting any issue anyway. If you really must keep track of the exact commit you built from, then don't do git pull without building, or make your own note of what commit you built from. Or look at the timestamp on /usr/bin/tmux.

…

On Sun, 24 Mar 2019, 08:20 Hirokazu Hata, ***@***.***> wrote: I don't think the build should have a dependency on the VCS I understand your thought. How do you think adding patch number to each code changes ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1650 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASkc6D3ZPQmpsgOeyO_jJSqrJCTdMUUks5vZzU7gaJpZM4cFRTb> .

[h-michael]

I see.
related issue #810

I decided to resolve my problem with this comment.
#810 (comment)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.