Doens't throw error when project file doesn't specify name #303
Conversation
the project.rb#name function forgot to check for nil adds a .blank check similarly to how .root works Adds a failing test case Adds a test case for the same behavior for #root (which already works) Fixes tmuxinator#302
|
Changes Unknown when pulling c0c2a60 on underscorenygren:no-error-when-no-name into * on tmuxinator:master*. |
2 similar comments
|
Changes Unknown when pulling c0c2a60 on underscorenygren:no-error-when-no-name into * on tmuxinator:master*. |
|
Changes Unknown when pulling c0c2a60 on underscorenygren:no-error-when-no-name into * on tmuxinator:master*. |
| @@ -31,7 +31,7 @@ def root | |||
|
|
|||
| def name | |||
| name = yaml["project_name"] || yaml["name"] | |||
| name.shellescape | |||
| name.blank? ? nil : name.shellescape | |||
There was a problem hiding this comment.
what about name.empty? Can a name be "" as well?
There was a problem hiding this comment.
Went with blank because that's what the #root fn did, but I don't think it
makes a difference.
On Wed, May 13, 2015 at 3:43 AM maxmeyer notifications@github.com wrote:
In lib/tmuxinator/project.rb
#303 (comment):@@ -31,7 +31,7 @@ def root
def name name = yaml["project_name"] || yaml["name"]
name.shellescapename.blank? ? nil : name.shellescapewhat about name.empty?
—
Reply to this email directly or view it on GitHub
https://github.com/tmuxinator/tmuxinator/pull/303/files#r30208295.
ghost
merged commit 
the
project.rb#namefunction forgot to check for niladds a
.blankcheck similarly to how#rootworksAdds a failing test case
Adds a test case for the same behavior for
#root(which already works)Fixes #302