Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the genericParser to be a new module called flow #209

Closed
4 tasks done
tngan opened this issue Sep 22, 2018 · 0 comments
Closed
4 tasks done

Refactor the genericParser to be a new module called flow #209

tngan opened this issue Sep 22, 2018 · 0 comments
Assignees
@tngan
Labels
rc Release candidate

Comments

@tngan
Copy link
Owner

tngan commented Sep 22, 2018 •
edited

The current genericParser function is just an aggregator of different flows, it makes the codebase hard to read, it's a good time to refactor this function since the extractor is already being extracted.

  • Handling login request
  • Handling login response
  • Handling logout request
  • Handling logout response
@tngan tngan added the rc Release candidate label Sep 22, 2018
tngan added a commit that referenced this issue Sep 23, 2018
@tngan
Refactor the genericParser to be a new module called flow #209
628e139
tngan added a commit that referenced this issue Sep 23, 2018
@tngan
Refactor the genericParser to be a new module called flow #209 (#210)
0fff5c0
@tngan tngan closed this as completed Sep 23, 2018
@tngan tngan self-assigned this Sep 23, 2018
tngan added a commit that referenced this issue Sep 26, 2018
@tngan
v2.4.0 rc3 (#211)
e3f37c4 
* Bump version

* 206 refactor extraction (#208)

#206 Refactor extraction of essential fields

* Refactor the genericParser to be a new module called flow #209 (#210)

* Fix internal logic to accept extracting attributes from multiple selected nodes

* Fix internal logic and wrap up the flow test suite

* Fix the internal function unit testing suite

* Fix internal logic and the test suite for previous issues

* Modify schema file to get rid of libxml2 limitation #198

* Specify schema directory instead of changing process directory (#195)

* Remove signature nodes properly

* Avoid potential signature wrapping attack

* Turn on debugger of the xsd validator during testing

* Add jdk into travis environment for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tngan tngan

Labels
rc Release candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tngan