Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange constraints: Destination directory 'webapp-instrumented' must be in the source directory #18

Closed
SebTardif opened this issue Nov 12, 2012 · 2 comments
Assignees
Labels

Comments

@SebTardif
Copy link

If I have webapp and webapp-instrumented as sibling folder, JSCover complains. I don't see any justification for this. Even more, if webapp-instrumented is a child of webapp, then JSCover recursives for ever.

C:\JSCover-0.0.11>java -jar C:\JSCover-0.0.11\target\dist\JSCover-all.jar -fs webapp webapp-instrumented
Destination directory 'webapp-instrumented' must be in the source directory
Usage: java -jar jscover.jar -fs [OPTION]... SOURCE-DIRECTORY DESTINATION-DIRECTORY
Instrument JavaScript with code coverage information.

Options:
--js-version=VERSION use the specified JavaScript version
--no-instrument=PATH copy but do not instrument PATH
--exclude=PATH don't copy from source/PATH
-h, --help display this help and exit

@tntim96
Copy link
Owner

tntim96 commented Nov 12, 2012

That's a bug. It Should read:
Destination directory 'webapp-instrumented' must not be in the source directory

The check that results in that message was supposed to prevent recursive copying (#16) - I'll try to fix them together.

tntim96 added a commit that referenced this issue Nov 12, 2012
Fix issue #18 - error message for destination in source directory incorrect
@tntim96
Copy link
Owner

tntim96 commented Nov 12, 2012

Can you try v0.0.12 and confirm that this is fixed?

@tntim96 tntim96 closed this as completed Nov 12, 2012
@ghost ghost assigned tntim96 Nov 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants