Only strip leading slashes from filenames when generating Cobertura reports #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a filename if it is a slash
tntim96
added a commit
that referenced
this pull request
Mar 5, 2013
Only strip leading slashes from filenames when generating Cobertura reports
|
Brilliant, thank you. |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #39, the leading slash in filenames is removed to ensure compatibility with Jenkins.
This works fine in web server mode when there is always a leading slash present, but if you are converting a JSON coverage file that has been generated in file system mode (as per issue #48) then there are no leading slashes and the initial character of the filename is removed blindly.
This patch will only remove the initial character in a filename if it's a slash.