feat: add external content download to octets:store directive
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #689 +/- ##
==========================================
- Coverage 50.18% 49.35% -0.84%
==========================================
Files 358 366 +8
Lines 11886 12543 +657
Branches 1276 1318 +42
==========================================
+ Hits 5965 6190 +225
- Misses 5921 6353 +432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tinovyatkin
approved these changes
Jul 4, 2024
Comment on lines
30
to
33
| if (Array.isArray(value)) | ||
| value = value.join(',') | ||
|
|
||
| for (const pair of value.split(',')) { |
There was a problem hiding this comment.
NIT: in case of array you first join the array to string just to split it on the next line.
Can we do the opposite?
if (typeof value === 'string')
value = value.split(',')
for (const pair of value) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation, feature.
Discussed request limit is not implemented. #688