Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention “previous“ commit in report #174

Closed
nomeata opened this issue Aug 7, 2014 · 2 comments
Closed

Mention “previous“ commit in report #174

nomeata opened this issue Aug 7, 2014 · 2 comments
Labels

Comments

@nomeata
Copy link
Contributor

nomeata commented Aug 7, 2014

When looking at a report, it is often not clear what commit the changes are relative to, especially when codespeed can get confused (#173). In order to debug that better, and also generally it would be nice to have that in the report.

Bonus points if it can be used for navigation. I could imagine two columns: One for the previous report (with summary), and one for the following (also with summary), if available. (Please ask if I did not make myself clear.)

@tobami
Copy link
Owner

tobami commented Aug 8, 2014

That's true, a report should save the previous revision it is using as baseline, and show it below "revision->commit" on the right.

I am not sure I understood the second part though: what two columns do you mean? The "time in seconds" one? One for the current, one for the previous revision? And what do you mean by "also with summary"?

@tobami tobami added the FEATURE label Aug 8, 2014
@nomeata
Copy link
Contributor Author

nomeata commented Aug 8, 2014

Maybe I shouldn’t have said columns. I guess something like this would work, putting it in the “Revision” box:

Revision
Commit   4b74f6ca3fb962e9e9ccff1665f4d941763101e4
Date     July 4, 2014, 1:35 a.m.
Repo     https://github.com/ghc/ghc/
Summary  test foo +10%
Prevoius deadbeef  (no significant changes)
Next     beefdead (test foo up 10%)

What I meant with columns was something like the following, on top of the page:

← deadbeef  (no significant changes)               beefdead (test foo up 10%) →    

but either design is fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants