Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple specifications #18

Open
jyasskin opened this issue Jun 20, 2018 · 6 comments
Open

Support multiple specifications #18

jyasskin opened this issue Jun 20, 2018 · 6 comments
Labels
enhancement

Comments

@jyasskin
Copy link
Contributor

jyasskin commented Jun 20, 2018 •
edited
Loading

https://github.com/WebBluetoothCG/web-bluetooth/ holds two specifications, index.bs and scanning.bs. It'd be nice for pr-preview to be able to build both.
jyasskin added a commit to WebBluetoothCG/web-bluetooth that referenced this issue Jun 20, 2018
@jyasskin
Add a PR-Preview configuration file
93eb43f 
See https://github.com/tobie/pr-preview#configuration-file for documentation.

This only supports the main Web Bluetooth specification. tobie/pr-preview#18 tracks being able to preview the scanning spec as well.
@jyasskin jyasskin mentioned this issue Jun 20, 2018
Merged
reillyeon pushed a commit to WebBluetoothCG/web-bluetooth that referenced this issue Jun 20, 2018
@jyasskin @reillyeon
Add a PR-Preview configuration file (#400)
68c5a71 
See https://github.com/tobie/pr-preview#configuration-file for documentation.

This only supports the main Web Bluetooth specification. tobie/pr-preview#18 tracks being able to preview the scanning spec as well.
reillyeon added a commit to WICG/webusb that referenced this issue Jun 20, 2018
@reillyeon
Add a PR-Preview configuration file
ee631d6 
See https://github.com/tobie/pr-preview#configuration-file for documentation.

This only supports the main WebUSB specification. tobie/pr-preview#18 tracks being able to preview the testing spec as well.
@reillyeon reillyeon mentioned this issue Jun 20, 2018
Merged
jyasskin pushed a commit to WICG/webusb that referenced this issue Jun 20, 2018
@reillyeon @jyasskin
Add a PR-Preview configuration file
c8b978f 
See https://github.com/tobie/pr-preview#configuration-file for documentation.

This only supports the main WebUSB specification. tobie/pr-preview#18 tracks being able to preview the testing spec as well.
@upsuper upsuper mentioned this issue Jul 16, 2018
Open
@foolip foolip mentioned this issue Nov 20, 2019
Closed
@wolenetz
Copy link

The MSE spec (https://github.com/w3c/media-source) also has multiple respec sources (main + bytestream format registry + various bytestream formats). Supporting previews & diffs for more than just the main spec would be very helpful.

wolenetz added a commit to w3c/media-source that referenced this issue Jan 30, 2020
@wolenetz
Add support for PR-Previews for the main MSE spec
3e56e27 
This only adds previews and diffs for the main MSE spec src file (media-source-respec.html), not the various bytestream format registry and format specs. See tobie/pr-preview#18 for potentially adding support for previewing PRs for multiple specs within a repo.
This was referenced Jan 30, 2020
Merged
Open
@beaufortfrancois beaufortfrancois mentioned this issue Feb 28, 2020
Closed
tidoust pushed a commit to w3c/media-source that referenced this issue Nov 24, 2020
@wolenetz
Add support for PR-Previews for the main MSE spec (#252)
2eb4cac 
This only adds previews and diffs for the main MSE spec src file (media-source-respec.html), not the various bytestream format registry and format specs. See tobie/pr-preview#18 for potentially adding support for previewing PRs for multiple specs within a repo.
@kdashg kdashg mentioned this issue Feb 3, 2021
Closed
@kdashg
Copy link

kdashg commented Feb 3, 2021

There are a couple designs to choose from here:

  1. Keep single-file schema, use multiple .pr-preview.json files
  2. Break schema compat and change it to an array of specs (basically an array of the current schema'd config object)
  3. Hybrid or versioned schema with optional multiple spec support

@tobie What do you recommend?

@tobie
Copy link
Owner

tobie commented Feb 3, 2021

We can’t break backwards compat and only have access to the .pr-preview.json
file in the repo, so option 3 is the most likely candidate.

Would be important to work with repos that have a high number of files, such as the CSS WG’s to make sure their needs are covered.

@chcunningham chcunningham mentioned this issue Mar 6, 2021
Merged
@chcunningham
Copy link

FYI similar issue for spec-prod at w3c/spec-prod#31. Lots of affected specs. @jdashg are you still pursuing option 3 above?

@tobie tobie mentioned this issue Apr 19, 2021
Open
@jeremyroman jeremyroman mentioned this issue Sep 3, 2021
Merged
@jeremyroman jeremyroman mentioned this issue Oct 6, 2021
Open
@xfq xfq mentioned this issue Nov 26, 2021
Merged
@irori irori mentioned this issue Mar 4, 2022
Merged
@nigelmegitt
Copy link

Also would be helpful to support multiple specs at w3c/ttwg for yet-to-be-pushed boilerplate Registry spec.

@tobie
Copy link
Owner

tobie commented Feb 9, 2023

There’s an open PR but no o traction on it. Resources are still the concern here. Not sure anything will move until that changes, unfortunately.

@nigelmegitt nigelmegitt mentioned this issue Feb 20, 2023
Merged
@patrickkettner patrickkettner mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tobie @jyasskin @kdashg @nigelmegitt @wolenetz @chcunningham