Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

Unreachable code in Python port #89

Closed
tobie opened this issue Nov 12, 2012 · 1 comment
Closed

Unreachable code in Python port #89

tobie opened this issue Nov 12, 2012 · 1 comment
Assignees
@elsigh

Comments

@tobie
Copy link
Owner

tobie commented Nov 12, 2012

Seems code contained in the if statement at https://github.com/tobie/ua-parser/blob/master/py/ua_parser/user_agent_parser.py#L250 should never be reached because of https://github.com/tobie/ua-parser/blob/master/py/ua_parser/user_agent_parser.py#L245.

Not sure if that's deliberate or a typo.
@ghost ghost assigned elsigh Nov 12, 2012
@tobie tobie mentioned this issue Nov 12, 2012
Closed
@elsigh
Copy link
Contributor

elsigh commented Nov 14, 2012

Fixed in merged pull request just now, thanks

@elsigh elsigh closed this as completed Nov 14, 2012
skliffmueller pushed a commit to skliffmueller/ua-parser that referenced this issue Oct 22, 2015
@commenthol
Merge pull request tobie#89 from commenthol/cfnetwork-ios9
3dd99d7 
iOS 9 Apps using CFNetwork
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elsigh elsigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobie @elsigh