Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change widgets names #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nikitamos
Copy link

Several widgets in the src/Main_Window.ui file had the same name ("widget"), for several users AQEMU crashed with SEGFAULT. So, the names were changed and now everything works fine

I changed them in Qt Designer, it automatically cutted several lines...

Several widgets in the src/Main_Window.ui file had the same name ("widget"), for several users AQEMU crashed with SEGFAULT. So, the names were changed and now everything works fine
@SirMangler
Copy link

Built on latest Arch. Can confirm this change fixes the otherwise unusable master. Please merge with confidence!

Thanks @nikitamos!

@spillner
Copy link

Can confirm this fixes the segfault, and should be merged.

@GermanAizek
Copy link

@nikitamos, @SirMangler, @spillner many thanks for contributing!
I merge your commit in active AQEMU Qt6 fork. I'm going to port AQEMU to Windows, it used to work but stopped. And it is also possible to fix bugs and rewrite to simpler QML code, widgets have too much .ui and C++ code. Weblate integration will be used for translation.
AQEMU/aqemu@dc19121
I did not touch your authorship commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants