Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

[WIP] Fix the nginx config file #71

Merged
merged 2 commits into from
Jan 23, 2020
Merged

[WIP] Fix the nginx config file #71

merged 2 commits into from
Jan 23, 2020

Conversation

Schrolli91
Copy link
Collaborator

This PR should fix the issue #61

  • serve query params to the url
  • adds caching for static asset files

@Schrolli91 Schrolli91 self-assigned this Jan 22, 2020
@Schrolli91 Schrolli91 added the bug Something isn't working label Jan 22, 2020
@Schrolli91 Schrolli91 changed the title Fix the nginx config file [WIP] Fix the nginx config file Jan 22, 2020
tobybatch
tobybatch previously approved these changes Jan 22, 2020
Copy link
Owner

@tobybatch tobybatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks pal. I was all at sea.

@tobybatch
Copy link
Owner

If this fixes it can we close the issues?

@Schrolli91
Copy link
Collaborator Author

Yes i think that should fix the problem, which is addressed in the issue.

compose/nginx_site.conf Outdated Show resolved Hide resolved
compose/nginx_site.conf Outdated Show resolved Hide resolved
nginx is in foreground and will print everything to stdout
@Schrolli91
Copy link
Collaborator Author

@tobybatch
if there no other doubts - we can merge this PR in my opinion

@kevinpapst
Copy link
Collaborator

GO GO GO 😁

@tobybatch tobybatch merged commit 9237fef into master Jan 23, 2020
@Schrolli91 Schrolli91 deleted the fix_nginx_conf branch January 23, 2020 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants