Stop installing a global __WARN__ handler at BEGIN time #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing a global __WARN__ handler when the package is loaded causes extremely surprising action at a distance, particularly as no attempt is made to call the previous __WARN__ handler, if it existed. Limit the scope of the warn handler to the single block which might cause the warnings.
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Jan 3, 2014
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Jan 4, 2014
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Apr 7, 2014
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Jun 16, 2014
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Jun 18, 2014
alexmv
added a commit
to bestpractical/rt
that referenced
this pull request
Jun 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing a global WARN handler when the package is loaded causes
extremely surprising action at a distance, particularly as no attempt is
made to call the previous WARN handler, if it existed.
Limit the scope of the warn handler to the single block which might
cause the warnings.