18ZOO - Update StockMarket to show bigger cells when there is any user info in any cell #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r info in any cell
carlorusso1984
commented
Oct 6, 2023
| @@ -69,7 +69,7 @@ class StockMarket < Snabberb::Component | |||
| textAlign: 'center', | |||
| position: 'absolute', | |||
| bottom: "#{PAD}px", | |||
| width: "#{WIDTH_TOTAL - (2 * PAD) - (2 * BORDER)}px", | |||
| width: "#{WIDTH_TOTAL + PRICE_HEIGHT - (2 * PAD) - (2 * BORDER)}px", | |||
There was a problem hiding this comment.
I added PRICE_HEIGHT to both width and height to keep the cells as square
|
i reverted this, does this change the default stock market look? |
|
It should change only the stock market when used as 2D and there are userInfo |
Merged
4 tasks
Can you check again? Carlo answer it it is only here. |
|
@serpentium I have done this new PR to avoid changing default stock market: #9790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9693
Before clicking "Create"
masterpinslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
As requested inside the issue, the stock market was updated to support the info, but only for the 2d grid
Screenshots