Improve how elf2tab parses ELF files #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use safer ELF parsing methods to find the fields we need.
|
Why are the RAM segments different for |
|
.stack is set to noload and does not generate a segment.
…On Wed, Jun 24, 2020, 3:16 PM Alistair Francis ***@***.***> wrote:
Why are the RAM segments different for libtock-rs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALGL4QHCFUTRIDXZ3OBYRTRYJGIXANCNFSM4OHCM4MA>
.
|
bradjc
commented
Jun 25, 2020
ppannuto
approved these changes
Jun 26, 2020
README.md
Outdated
| instead of being position independent. To detect a fixed flash address, elf2tab | ||
| looks to see if the flash segment is at the dummy flash address for PIC apps or | ||
| not. To detect a fixed RAM address, elf2tab looks for a `_sram_origin` symbol, | ||
| and checks if the address matches the dummy RAM address for PIC apps or not. |
There was a problem hiding this comment.
What does elf2tab do if there is neither a _sram_origin symbol nor does the PIC address match? (I'll read the code in a second, but I think the intent should probably be specified here (i.e. will/should it error?))
There was a problem hiding this comment.
No, that would break backwards compatibility. elf2tab just does what it does now: nothing.
Comment on lines
+188
to
+190
| // by the app when it first starts. If for some reason an app is PIC and | ||
| // wants to use different dummy PIC addresses, then this logic will have to | ||
| // be updated. |
There was a problem hiding this comment.
Not for this PR, but I think this logic shouldn't change; rather these constant should just be exposed as flags.
bradjc
commented
Jun 26, 2020
|
Haha, there's no bors ... or even tests (😢) ... in this repo is there |
|
There are tests! But bors doesn't do anything if there is only one PR/week or month or year. |
bors bot
added a commit
to tock/libtock-rs
that referenced
this pull request
Jul 7, 2020
208: linker: add sram origin symbol r=bradjc a=bradjc This allows elf2tab to determine what the start of RAM address is when generating a fixed address header in the TBF. See tock/elf2tab#23 and tock/tock#1845. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things: