Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Default implementation with derived Default in RNG capsule #1080

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Replace Default implementation with derived Default in RNG capsule #1080

merged 1 commit into from
Jul 6, 2018

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Jul 6, 2018 •
edited
Loading

Pull Request Overview

This pull request removes the needless default implementation for App in the rng capsule!

Testing Strategy

This pull request was tested by compiles

TODO or Help Wanted

N/A

Documentation Updated

- [ ] Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@alevy alevy changed the title rng-capsule remove needless default implementation Replace Default implementation with derived Default in RNG capsule Jul 6, 2018
@alevy
Copy link
Member

alevy commented Jul 6, 2018

Would be good to at least spot test with hardware.

@alevy alevy added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Jul 6, 2018
bradjc
bradjc approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Hail with the RNG test app and the app worked as expected.

@niklasad1
Copy link
Member Author

Thanks @bradjc

@niklasad1 niklasad1 merged commit 48f4834 into master Jul 6, 2018
@niklasad1 niklasad1 deleted the refactor/rng-capsule-remove-needless-default-impl branch July 6, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @alevy @bradjc