Updates to tock-registers for publishing #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
added
blocked
ppannuto
dismissed
bradjc’s stale review
I don't think that review applies to any of the changes for this PR? It's already blocked on #1105.
ppannuto
force-pushed
the
publish-tock-registers
branch
from
cd9340d
to
114bd69
Compare
ppannuto
removed
the
blocked
The doc tests are not optimized for macros or top-level declration examples, but here's the relevant bit for why this does what it does: https://doc.rust-lang.org/beta/rustdoc/documentation-tests.html#documenting-macros
ppannuto
force-pushed
the
publish-tock-registers
branch
from
114bd69
to
4359092
Compare
|
Rebased. This should be good to go now. |
bradjc
approved these changes
Jul 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is blocked on #1105.
This finishes the remaining bits for publishing, specifically fixing up doctests and adding metadata to the manifest.
Testing Strategy
Compiling.
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.