Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: s/regs/registers #1105
Pull Request Overview
Following a brief IRC discussion, update
Summary of IRC:
I think @bradjc and I have reached an impasse.
I would rather see a consistent use of
I would prefer to use words rather than arbitrary abbreviations. I think that's been agreed to for the
Anyone else care to weigh in?
I don't care strongly one way or another, but I'm sympathetic to @bradjc's concern about changing so many files on a whim (and the kernel interface for that matter).
Since we're re-exporting the registers interface from the kernel anyway, is a reasonable middle-ground to change the names in the
I don't feel strongly about this change either. Generally it's better to spell things out rather than abbreviate, but this mostly just feels like code churn to me.
On the consistency side, can you point to a problematic case? A grep through the codebase shows me that a lot of files have a
One source of concern, it seemed like @alevy and @bradjc were fine with this change when proposed on IRC. Was there something in particular that changed in this implementation from what you were imagining (maybe just the scale)? We should definitely avoid spending effort on things that aren't going to be wanted.
Why does it matter that 66 files change? What matters is what kind of change. If we decided to add a license to every source file we'd change every one of them. If it relates to package names, so be it.
That being said, going through lots of files written by other people and changing their variable names because one doesn't like them isn't great behavior.