New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A directory for crates #1006

Merged
merged 3 commits into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@brghena
Copy link
Contributor

brghena commented Jun 19, 2018

Pull Request Overview

Moves the tock register crate out of tools and into a directory that's just for crates we use internally, but want to share externally. This was discussed in #986 as we're thinking about making a crate just for our cell implementations too.

The current name for the directory is libraries/ and it lives in the root of the Tock repo. Both the name and location are very much open for discussion.

Note: this PR is blocked until #984 is pulled.

Testing Strategy

make allboards still works

TODO or Help Wanted

I'm open to opinions on how this should be handled and what the directory should be named.

Documentation Updated

  • Kernel: Updated the relevant files in /docs, or no updates are required.
  • N/A Userland: Added/updated the application README, if needed.

Formatting

  • Ran make formatall.

@brghena brghena changed the title Theres a place for crates A directory for crates Jun 19, 2018

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jun 19, 2018

I'm fine with libraries, but prefer extern

@bradjc bradjc added the blocked label Jun 19, 2018

@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jun 19, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 19, 2018

I think libraries is a good option. To me, extern implies that someone else wrote the code.

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jun 19, 2018

libraries is fine

brghena added some commits Jun 19, 2018

@bradjc bradjc force-pushed the theres-a-place-for-crates branch from cf74488 to 135de0f Jun 22, 2018

@bradjc bradjc added P-Upkeep and removed blocked labels Jun 22, 2018

@bradjc

bradjc approved these changes Jun 22, 2018

@bradjc bradjc added the last-call label Jun 25, 2018

@bradjc bradjc merged commit 13c9da6 into master Jun 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bradjc bradjc deleted the theres-a-place-for-crates branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment