A directory for crates #1006
Merged
A directory for crates #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with |
bradjc
added
the
blocked
|
Do I misattribute "extern" as meaning external to the Tock project? I
wouldn't expect things in an 'extern' folder to be maintained by the Tock
developers
…On Tue, Jun 19, 2018 at 5:49 PM Amit Levy ***@***.***> wrote:
I'm fine with libraries, but prefer extern
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1006 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUt3suiA3cufMDHnG5hmBoLm-gFNo5xks5t-TmlgaJpZM4Ut7tD>
.
|
|
I think libraries is a good option. To me, |
|
libraries is fine |
bradjc
force-pushed
the
theres-a-place-for-crates
branch
from
cf74488
to
135de0f
Compare
bradjc
added
P-Upkeep
bradjc
approved these changes
Jun 22, 2018
niklasad1
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Moves the tock register crate out of
toolsand into a directory that's just for crates we use internally, but want to share externally. This was discussed in #986 as we're thinking about making a crate just for our cell implementations too.The current name for the directory is
libraries/and it lives in the root of the Tock repo. Both the name and location are very much open for discussion.Note: this PR is blocked until #984 is pulled.
Testing Strategy
make allboardsstill worksTODO or Help Wanted
I'm open to opinions on how this should be handled and what the directory should be named.
Documentation Updated
/docs, or no updates are required.Userland: Added/updated the application README, if needed.Formatting
make formatall.