New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move architecture-dependent debugging print code to arch/cortex-m #1115

Merged
merged 2 commits into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@bradjc
Copy link
Contributor

bradjc commented Jul 14, 2018

Pull Request Overview

This pull finishes up #1113 by moving the SCB_REGISTERS variable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate.

I believe this is the last step to having process.rs be architecture agnostic.

Blocked on #1113.

Testing Strategy

This pull request was tested by running crash dummy and hail on hail and seeing the panic output.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@bradjc bradjc referenced this pull request Jul 14, 2018

Closed

Tracking: Make Tock Architecture Agnostic #985

9 of 9 tasks complete

bradjc added a commit that referenced this pull request Jul 17, 2018

@bradjc bradjc changed the title Move arch-specific debugging print to cortex-m crate Move architecture-dependent debugging print code to arch/cortex-m Jul 17, 2018

@bradjc bradjc referenced this pull request Jul 18, 2018

Merged

Kernel: add comments #1121

2 of 2 tasks complete

@ppannuto ppannuto added the blocked label Jul 18, 2018

@brghena brghena referenced this pull request Jul 30, 2018

Merged

Move architecture-dependent syscall code to arch/cortex-m #1113

2 of 2 tasks complete

@bradjc bradjc force-pushed the arch-agnostic7 branch from e227591 to 52abf2a Jul 31, 2018

bradjc added a commit that referenced this pull request Jul 31, 2018

@bradjc bradjc force-pushed the arch-agnostic7 branch 2 times, most recently from e63317f to 98129d5 Aug 13, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Aug 13, 2018

Ok please review! This moves the arch-specific debug printing to the arch crate.

@bradjc bradjc removed the blocked label Aug 13, 2018


/// Display architecture specific (e.g. CPU registers or status flags) data
/// for a process identified by its stack pointer.
unsafe fn print_process_arch_detail(

This comment has been minimized.

@alevy

alevy Aug 13, 2018

Member

my only complaint is the difference in naming between this method ( print_process_arch_detail) and fault_str. They do similar things---write a formatted string out to a Write, but one is print_ and the other is _str. Maybe fault_fmt and process_detail_fmt?

This comment has been minimized.

@bradjc

bradjc Aug 13, 2018

Contributor

Changed.

bradjc added some commits Jul 13, 2018

@bradjc bradjc force-pushed the arch-agnostic7 branch from 98129d5 to ae001a8 Aug 13, 2018

@alevy

alevy approved these changes Aug 14, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Aug 14, 2018

This PR isn't very exciting, and really should go quickly with #1113. So last call (it has been open for a month now).

@bradjc bradjc added the last-call label Aug 14, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Aug 16, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 16, 2018

Merge #1115
1115: Move architecture-dependent debugging print code to arch/cortex-m r=bradjc a=bradjc

### Pull Request Overview

This pull finishes up #1113 by moving the `SCB_REGISTERS` variable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate.

I believe this is the last step to having process.rs be architecture agnostic.

~~Blocked on #1113.~~


### Testing Strategy

This pull request was tested by running crash dummy and hail on hail and seeing the panic output.


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make formatall`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Aug 16, 2018

@bors bors bot merged commit ae001a8 into master Aug 16, 2018

4 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the arch-agnostic7 branch Aug 16, 2018

bors bot added a commit that referenced this pull request Aug 16, 2018

Merge #1121
1121: Kernel: add comments r=alevy a=bradjc

### Pull Request Overview

This pull request:

- Adds comments to data structures in the kernel.
- ~~Removes the need for `Callback` to be `mut` (which has ramifications for the capsules).~~
- ~~Removes the need for `Allocator` to be `mut`.~~

~~Blocked on #1115.~~

### Testing Strategy

This pull request was tested by compiling.


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make formatall`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>

@cmcavity cmcavity referenced this pull request Aug 22, 2018

Closed

Process faults #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment