Move architecture-dependent debugging print code to arch/cortex-m #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bradjc
changed the title
ppannuto
added
the
blocked
2 tasks
5 tasks
bradjc
force-pushed
the
arch-agnostic7
branch
2 times, most recently
from
e63317f
to
98129d5
Compare
|
Ok please review! This moves the arch-specific debug printing to the arch crate. |
bradjc
removed
the
blocked
alevy
reviewed
Aug 13, 2018
kernel/src/syscall.rs
Outdated
|
|
||
| /// Display architecture specific (e.g. CPU registers or status flags) data | ||
| /// for a process identified by its stack pointer. | ||
| unsafe fn print_process_arch_detail( |
There was a problem hiding this comment.
my only complaint is the difference in naming between this method ( print_process_arch_detail) and fault_str. They do similar things---write a formatted string out to a Write, but one is print_ and the other is _str. Maybe fault_fmt and process_detail_fmt?
alevy
approved these changes
Aug 14, 2018
|
This PR isn't very exciting, and really should go quickly with #1113. So last call (it has been open for a month now). |
ppannuto
approved these changes
Aug 15, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2018
1115: Move architecture-dependent debugging print code to arch/cortex-m r=bradjc a=bradjc ### Pull Request Overview This pull finishes up #1113 by moving the `SCB_REGISTERS` variable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate. I believe this is the last step to having process.rs be architecture agnostic. ~~Blocked on #1113.~~ ### Testing Strategy This pull request was tested by running crash dummy and hail on hail and seeing the panic output. ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2018
1121: Kernel: add comments r=alevy a=bradjc ### Pull Request Overview This pull request: - Adds comments to data structures in the kernel. - ~~Removes the need for `Callback` to be `mut` (which has ramifications for the capsules).~~ - ~~Removes the need for `Allocator` to be `mut`.~~ ~~Blocked on #1115.~~ ### Testing Strategy This pull request was tested by compiling. ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull finishes up #1113 by moving the
SCB_REGISTERSvariable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate.I believe this is the last step to having process.rs be architecture agnostic.
Blocked on #1113.Testing Strategy
This pull request was tested by running crash dummy and hail on hail and seeing the panic output.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.