-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move architecture-dependent debugging print code to arch/cortex-m #1115
Conversation
e63317f
to
98129d5
Compare
Ok please review! This moves the arch-specific debug printing to the arch crate. |
kernel/src/syscall.rs
Outdated
|
||
/// Display architecture specific (e.g. CPU registers or status flags) data | ||
/// for a process identified by its stack pointer. | ||
unsafe fn print_process_arch_detail( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only complaint is the difference in naming between this method ( print_process_arch_detail
) and fault_str
. They do similar things---write a formatted string out to a Write
, but one is print_
and the other is _str
. Maybe fault_fmt
and process_detail_fmt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
This PR isn't very exciting, and really should go quickly with #1113. So last call (it has been open for a month now). |
bors r+ |
1115: Move architecture-dependent debugging print code to arch/cortex-m r=bradjc a=bradjc ### Pull Request Overview This pull finishes up #1113 by moving the `SCB_REGISTERS` variable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate. I believe this is the last step to having process.rs be architecture agnostic. ~~Blocked on #1113.~~ ### Testing Strategy This pull request was tested by running crash dummy and hail on hail and seeing the panic output. ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Build succeeded |
1121: Kernel: add comments r=alevy a=bradjc ### Pull Request Overview This pull request: - Adds comments to data structures in the kernel. - ~~Removes the need for `Callback` to be `mut` (which has ramifications for the capsules).~~ - ~~Removes the need for `Allocator` to be `mut`.~~ ~~Blocked on #1115.~~ ### Testing Strategy This pull request was tested by compiling. ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Pull Request Overview
This pull finishes up #1113 by moving the
SCB_REGISTERS
variable to the cortex-m crate and all of the printing code that is architecture specific to the cortex-m crate.I believe this is the last step to having process.rs be architecture agnostic.
Blocked on #1113.Testing Strategy
This pull request was tested by running crash dummy and hail on hail and seeing the panic output.
TODO or Help Wanted
n/a
Documentation Updated
/docs
, or no updates are required.Formatting
make formatall
.