kernel: make user-kernel boundary in Chip #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
force-pushed
the
new-mpu-new-chip
branch
from
6282006
to
4561a1c
Compare
9 tasks
|
This should be rejected or merged before release testing (obviously I vote merged!). |
bradjc
added
the
release-blocker
ppannuto
requested changes
Oct 26, 2018
This removes the burden that the board author has to think about this, since once the chip has been decided, the architecture has been decided as well.
ppannuto
force-pushed
the
new-mpu-new-chip
branch
from
4561a1c
to
0891b60
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 29, 2018
1191: kernel: make user-kernel boundary in Chip r=alevy a=bradjc
### Pull Request Overview
This pull request adds a new trait type to the `Chip` trait that represents the code that handles switching between kernelspace and userspace. Because this is a hardware feature, it makes sense to include it with the chip so that a user doesn't accidentally choose the wrong arch for a given MCU.
```rust
pub trait Chip {
type MPU: mpu::MPU;
type UserspaceKernelBoundary: syscall::UserspaceKernelBoundary;
type SysTick: systick::SysTick;
...
```
This also simplifies main.rs as now setting up processes and the kernel only requires passing in the chip.
### Testing Strategy
This pull request was tested by running a hail kernel.
### TODO or Help Wanted
n/a
### Documentation Updated
- [x] Updated the relevant files in `/docs`, or no updates are required.
### Formatting
- [x] Ran `make formatall`.
Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a new trait type to the
Chiptrait that represents the code that handles switching between kernelspace and userspace. Because this is a hardware feature, it makes sense to include it with the chip so that a user doesn't accidentally choose the wrong arch for a given MCU.This also simplifies main.rs as now setting up processes and the kernel only requires passing in the chip.
Testing Strategy
This pull request was tested by running a hail kernel.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.