Make nrf52* based boards compatible with bootloader. #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichelp
added a commit
to jmichelp/OpenSK
that referenced
this pull request
Mar 11, 2020
Now the script supports more flashing methods: - JLink (with tockloader) - OpenOCD (with tockloader) - pyOCD - Nordic DFU - none (will produce an IntelHex file) Also merged the contributions from: - Yihui Xiong to support the Makerdiary USB dongle board - Dennis Geurts to support Nordic DFU Doc updated accordingly. Imported 2 patches for Tock kernel: - 06-add-set_vector_table_offset.patch (upstream tock/tock#1579) - 07-nrf52-bootloader.patch (upstream tock/tock#1681)
jmichelp
added a commit
to jmichelp/OpenSK
that referenced
this pull request
Mar 11, 2020
Now the script supports more flashing methods: - JLink (with tockloader) - OpenOCD (with tockloader) - pyOCD - Nordic DFU - none (will produce an IntelHex file) Also merged the contributions from: - Yihui Xiong to support the Makerdiary USB dongle board - Dennis Geurts to support Nordic DFU Doc updated accordingly. Imported 2 patches for Tock kernel: - 06-add-set_vector_table_offset.patch (upstream tock/tock#1579) - 07-nrf52-bootloader.patch (upstream tock/tock#1681)
|
The bootloader doesn't do this? |
jmichelp
added a commit
to jmichelp/OpenSK
that referenced
this pull request
Mar 11, 2020
Now the script supports more flashing methods: - JLink (with tockloader) - OpenOCD (with tockloader) - pyOCD - Nordic DFU - none (will produce an IntelHex file) Also merged the contributions from: - Yihui Xiong to support the Makerdiary USB dongle board - Dennis Geurts to support Nordic DFU Doc updated accordingly. Imported 2 patches for Tock kernel: - 06-add-set_vector_table_offset.patch (upstream tock/tock#1579) - 07-nrf52-bootloader.patch (upstream tock/tock#1681)
|
It can't. The bootloader comes with its own interrupt vectors and jumps to the app (in our case Tock). This way, if the app is faulty, it can stay in the bootloader and you can recover your board. This means that Tock need to set the offset to be able to use its own interrupt vector. If there's no bootloader, this will be equivalent to a no-op as we're setting the vectors to 0x0 which is the value at reset. |
|
Well it can, since the Tock bootloader does, but I see your point. |
bradjc
reviewed
Mar 11, 2020
Co-Authored-By: Brad Campbell <bradjc5@gmail.com>
bradjc
approved these changes
Mar 11, 2020
kaczmarczyck
pushed a commit
to kaczmarczyck/OpenSK
that referenced
this pull request
Mar 12, 2020
Now the script supports more flashing methods: - JLink (with tockloader) - OpenOCD (with tockloader) - pyOCD - Nordic DFU - none (will produce an IntelHex file) Also merged the contributions from: - Yihui Xiong to support the Makerdiary USB dongle board - Dennis Geurts to support Nordic DFU Doc updated accordingly. Imported 2 patches for Tock kernel: - 06-add-set_vector_table_offset.patch (upstream tock/tock#1579) - 07-nrf52-bootloader.patch (upstream tock/tock#1681)
bradjc
added
release-blocker
niklasad1
approved these changes
Mar 18, 2020
|
bors r+ |
Timed out |
|
That's cool, bors, that's cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request makes Tock OS compatible with a bootloader on all boards that are based on nrf52 chip family.
The offset is determined by the linker. This way the board layout defines the offset.
Testing Strategy
This pull request was tested by flashing OpenSK on a nRF52840DK board using JLink, flashing it on a nRF52840 USB dongle using
nordicdfutool as well as flashing OpenSK firmware on a nRF52840-MDK USB dongle over DFU.TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.